Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation linking #235

Merged
merged 4 commits into from
May 27, 2024
Merged

Fix documentation linking #235

merged 4 commits into from
May 27, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented May 23, 2024

I still discovered some missing links since the refactoring of the docs.

I will continue on Monday to search for more gaps.

@Lotes Lotes temporarily deployed to pull-request-preview May 23, 2024 15:16 — with GitHub Actions Inactive
Copy link

github-actions bot commented May 23, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-05-27 12:06 UTC

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why keep lexis in the url for the lexing recipes?

Also, you missed one:

By default, the parser will create an object with an inferred type corresponding to the parser rule name. It is possible to override this behavior by explicitly defining the type of the object to be created. This is done by adding the keyword `returns` followed by a separately declared type, or the keyword `infers` followed by the name of the type to be inferred for this rule (more about this [in the next chapter](../sematic-model)):

Otherwise, looks good to me 👍

@Lotes
Copy link
Contributor Author

Lotes commented May 23, 2024

I think it would be good to have a script doing this checking task.

EDIT: Did so here: #237

@Lotes Lotes temporarily deployed to pull-request-preview May 27, 2024 06:55 — with GitHub Actions Inactive
@Lotes Lotes marked this pull request as ready for review May 27, 2024 08:57
@Lotes
Copy link
Contributor Author

Lotes commented May 27, 2024

@msujew I fixed the two findings of you, the remaining issues can be fixed in #237 .

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lotes Lotes merged commit 398b361 into main May 27, 2024
4 checks passed
@Lotes Lotes deleted the lotes/fix-links branch May 27, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants