Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Customize linking errors #230

Merged
merged 2 commits into from
May 23, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented May 15, 2024

Addresses and closes #226

For the moment I am using warnings instead of errors for failed linking.

This PR is in draft mode, so I will change the implementation along the discussion inside of the issue.

@Lotes Lotes temporarily deployed to pull-request-preview May 15, 2024 14:42 — with GitHub Actions Inactive
Copy link

github-actions bot commented May 15, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-05-23 12:09 UTC

@Lotes Lotes marked this pull request as ready for review May 21, 2024 12:09
@Lotes
Copy link
Contributor Author

Lotes commented May 22, 2024

Please have a look at my wording. Maybe you find a better way of expressing the warning. Otherwise I would be happy about an approval

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Lotes Lotes merged commit 454c8ce into main May 23, 2024
4 checks passed
@Lotes Lotes deleted the lotes/226-customize-playgrounds-linking-errors branch May 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playground displays misleading linker errors
2 participants