Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment only out of .json files #222 Bug Fix #245

Merged

Conversation

AnishVallolikalathilAchuthadas
Copy link
Contributor

Deployment only out of .json files #222 Bug Fix

Signed-off-by: Anish Vallolikalathil Achuthadas <[email protected]>
Copy link
Contributor

@dimitar-dimitrow dimitar-dimitrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is about the deployment service, not the CLI create command. Deployment service allows containers to be created and started automatically from CM daemon upon start. Check /containerm/deployment/deployment.go file and the Deployment properties in the doc.

Copy link
Contributor

@dimitar-dimitrow dimitar-dimitrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add unit tests for the new checks in cli_command_ctrs_create_test.go and deployment_test.go.
  2. Make sure that the code passes the validation workflow:
  • gofmt -l .
  • golint -set_exit_status ./...
  • go vet ./...
  • go test ./...

containerm/deployment/deployment.go Outdated Show resolved Hide resolved
@dimitar-dimitrow dimitar-dimitrow linked an issue Jun 18, 2024 that may be closed by this pull request
@dimitar-dimitrow dimitar-dimitrow merged commit 121a570 into eclipse-kanto:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment only out of .json files
2 participants