Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox2-51 integrate posix condition variable for mac os #52

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 19, 2023

Notes for Reviewer

This is the first of some PR for mac os support. In this PR the mac os condition variable is finalized by using a low level semaphore based on atomics and atomic wait operations.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #51

@elfenpiff elfenpiff self-assigned this Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f05ce41) 77.86% compared to head (f2b5c68) 77.89%.
Report is 1 commits behind head on main.

❗ Current head f2b5c68 differs from pull request most recent head 05d43b0. Consider uploading reports for the commit 05d43b0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   77.86%   77.89%   +0.03%     
==========================================
  Files         171      172       +1     
  Lines       18638    18664      +26     
==========================================
+ Hits        14513    14539      +26     
  Misses       4125     4125              
Files Coverage Δ
...yx2-pal/concurrency-sync/src/condition_variable.rs 100.00% <100.00%> (ø)
iceoryx2-pal/concurrency-sync/src/lib.rs 100.00% <100.00%> (ø)
iceoryx2-pal/concurrency-sync/src/mutex.rs 94.64% <100.00%> (+0.30%) ⬆️
iceoryx2-pal/concurrency-sync/src/semaphore.rs 93.10% <100.00%> (+1.72%) ⬆️
iceoryx2-pal/concurrency-sync/src/rwlock.rs 97.84% <95.00%> (-0.34%) ⬇️

Copy link
Member

@elBoberido elBoberido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

…djust semantics of wait call (was wrong before, corrected but the tests weren't adjusted)
@elfenpiff elfenpiff mentioned this pull request Dec 20, 2023
17 tasks
@elfenpiff elfenpiff force-pushed the iox2-51-finalize-mac-os-support branch 2 times, most recently from f2b5c68 to 05d43b0 Compare December 20, 2023 17:42
@elfenpiff elfenpiff merged commit 5d54039 into eclipse-iceoryx:main Dec 21, 2023
15 checks passed
@elfenpiff elfenpiff deleted the iox2-51-finalize-mac-os-support branch December 21, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants