Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#460] Add Rust feature flag to cmake #471

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Oct 16, 2024

Notes for Reviewer

This PR makes the Rust feature flags available to cmake.

To minimize boilerplate code, a add_rust_feature cmake macro is added.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Closes #460

@elBoberido elBoberido self-assigned this Oct 16, 2024
@elBoberido elBoberido force-pushed the iox2-460-add-dev-permission-flag-to-cmake branch from bbbce2a to eba578e Compare October 16, 2024 03:29
@elBoberido elBoberido force-pushed the iox2-460-add-dev-permission-flag-to-cmake branch from eba578e to a390fe3 Compare October 16, 2024 03:42
@elBoberido elBoberido merged commit 558c727 into eclipse-iceoryx:main Oct 16, 2024
54 checks passed
@elBoberido elBoberido deleted the iox2-460-add-dev-permission-flag-to-cmake branch October 16, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developer permissions for resources
2 participants