-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#213] improves test cases for unique_id and adaptive_waiter #462
[#213] improves test cases for unique_id and adaptive_waiter #462
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
- Coverage 79.14% 79.13% -0.01%
==========================================
Files 196 196
Lines 23538 23572 +34
==========================================
+ Hits 18628 18653 +25
- Misses 4910 4919 +9
|
b240a30
to
61c0a98
Compare
61c0a98
to
32dd773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as the CI is green we can merge it.
As always, thank you providing additional test cases and the great work!
Cool, I'm still trying to learning each component step by step as I don't have some experiences for the low level programming. I hope I can raise some useful features in the future(probably Q1 2025)! |
Notes for Reviewer
During reading code, I have found the room to improve the test cases so I have changed them for a better test cases.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Updates #213