Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#213] improves test cases for unique_id and adaptive_waiter #462

Conversation

xieyuschen
Copy link
Contributor

@xieyuschen xieyuschen commented Oct 13, 2024

Notes for Reviewer

During reading code, I have found the room to improve the test cases so I have changed them for a better test cases.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked in the References section
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Updates #213

@xieyuschen xieyuschen changed the title [213] improves test cases for unique_id and adaptive_waiter [#213] improves test cases for unique_id and adaptive_waiter Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (af0ad0e) to head (32dd773).
Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
- Coverage   79.14%   79.13%   -0.01%     
==========================================
  Files         196      196              
  Lines       23538    23572      +34     
==========================================
+ Hits        18628    18653      +25     
- Misses       4910     4919       +9     
Files with missing lines Coverage Δ
iceoryx2-bb/posix/src/unique_system_id.rs 96.10% <100.00%> (+3.08%) ⬆️

... and 5 files with indirect coverage changes

@xieyuschen xieyuschen force-pushed the iox2-213-posix-tests-uniid-and-waiter branch from b240a30 to 61c0a98 Compare October 14, 2024 09:41
@xieyuschen xieyuschen force-pushed the iox2-213-posix-tests-uniid-and-waiter branch from 61c0a98 to 32dd773 Compare October 14, 2024 13:21
Copy link
Contributor

@elfenpiff elfenpiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the CI is green we can merge it.

As always, thank you providing additional test cases and the great work!

@xieyuschen
Copy link
Contributor Author

As soon as the CI is green we can merge it.

As always, thank you providing additional test cases and the great work!

Cool, I'm still trying to learning each component step by step as I don't have some experiences for the low level programming. I hope I can raise some useful features in the future(probably Q1 2025)!

@elBoberido elBoberido merged commit 8a61101 into eclipse-iceoryx:main Oct 14, 2024
55 checks passed
@xieyuschen xieyuschen deleted the iox2-213-posix-tests-uniid-and-waiter branch October 15, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants