-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#390] waitset c binding #451
[#390] waitset c binding #451
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 79.00% 79.03% +0.03%
==========================================
Files 196 196
Lines 23251 23373 +122
==========================================
+ Hits 18369 18473 +104
- Misses 4882 4900 +18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, comments are mainly for superficial changes. The motivation, however, is to make the API as self-explanatory to future devs as possible by reducing the number of "cognitive steps" required to understand what is being done.
For example, with attach_notification
, the question arises "what is a notification?", but this IMO is not information worth keeping track of when working with the WaitSet.
…o WaitSetAttachmentId
…rom -> has_missed_deadline
Notes for Reviewer
The language bindings for C and C++. The C API is tested through the C++ API, which utilizes it fully.
The
event-multiplexing
example is not yet ported - this comes later.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #390