Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 5 add more tests #47

Merged
merged 5 commits into from
Jun 30, 2022
Merged

Iox 5 add more tests #47

merged 5 commits into from
Jun 30, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 30, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

Add a few more tests, update documentation and a small API adjustment

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added documentation Improvements or additions to documentation test labels Jun 30, 2022
@elBoberido elBoberido self-assigned this Jun 30, 2022
@elBoberido elBoberido merged commit d7480a4 into master Jun 30, 2022
@elBoberido elBoberido deleted the iox-5-add-more-tests branch June 30, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant