Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox 5 add coverage #25

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Iox 5 add coverage #25

merged 5 commits into from
Jun 27, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 22, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the Rust coding style and is formatted with rustfmt
  2. Branch follows the naming format (iox-#123-this-is-a-branch)
  3. Commits messages are according to this guideline
  4. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  5. Relevant issues are linked
  6. Add sensible notes for the reviewer
  7. All checks have passed (except task-list-completed)
  8. Assign PR to reviewer

Notes for Reviewer

This PR adds a CI job for test coverage and uploads the result to codecov.

To speed up the CI, the builds are now also cached and clippy reuses the build artifacts or a previous build.

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-5-add-coverage branch 10 times, most recently from ca2f0b6 to bb1fd88 Compare June 22, 2022 23:55
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@d0813f9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   38.97%           
=========================================
  Files             ?       17           
  Lines             ?     4180           
  Branches          ?        0           
=========================================
  Hits              ?     1629           
  Misses            ?     2551           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0813f9...5d1486c. Read the comment docs.

@elBoberido elBoberido force-pushed the iox-5-add-coverage branch 17 times, most recently from 8fe024a to df247fc Compare June 23, 2022 23:24
@elBoberido elBoberido changed the base branch from master to iox-#5-add-roudi-environment June 23, 2022 23:28
@elBoberido elBoberido requested a review from dkroenke June 23, 2022 23:29
@elBoberido elBoberido self-assigned this Jun 23, 2022
@elBoberido elBoberido marked this pull request as ready for review June 23, 2022 23:31
@elBoberido elBoberido changed the base branch from iox-#5-add-roudi-environment to master June 25, 2022 16:49
@elBoberido elBoberido force-pushed the iox-5-add-coverage branch 7 times, most recently from 3a0601d to 661d735 Compare June 25, 2022 17:58
@elBoberido elBoberido changed the base branch from master to iox-#5-add-roudi-environment June 25, 2022 18:05
@elBoberido elBoberido changed the base branch from iox-#5-add-roudi-environment to master June 27, 2022 10:46
@elBoberido elBoberido merged commit 08b520f into master Jun 27, 2022
@elBoberido elBoberido deleted the iox-5-add-coverage branch June 27, 2022 10:55
@elBoberido elBoberido linked an issue Jun 27, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create integration tests
2 participants