Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use feedback dispatcher for change bounds feedback #262

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Use feedback dispatcher for change bounds feedback #262

merged 1 commit into from
Jul 12, 2023

Conversation

planger
Copy link
Member

@planger planger commented Jul 11, 2023 •
edited
Loading

Fixes eclipse-glsp/glsp#941

How I tested this:

  1. move and resize elements and then hit Escape to see if the feedback is properly reset
  2. install a timer to periodically send an updatemodelaction from the server and see if the visual feedback for move isn't disturbed and correctly re-applied after each model update from the server

martin-fleck-at
martin-fleck-at approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as advertised, thank you for the great fix! LGTM!

@martin-fleck-at martin-fleck-at merged commit 7be33cd into master Jul 12, 2023
5 checks passed
@martin-fleck-at martin-fleck-at deleted the planger/issues/941 branch July 12, 2023 07:04
@planger planger mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-fleck-at martin-fleck-at martin-fleck-at approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change bounds feedback is not dispatched as a feedback action
3 participants
@planger @martin-fleck-at @tortmayr