Refactor code base #259
Merged
Refactor code base #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `FeedbackActionDispatcher` and related components into base package - Refactor `FeedbackAwareModelCommand`. Remove `ModelRootChangeListener` API from this command and add it to the command stack instead. This ensures that the model listeners are notified after the update has been processed succeessfully. It also makes it easier to rebind the `UpdateModelCommand` as you don't have to consider the listeners anymore.
- Remove unnecessary Types.SelectionService binding and bind SelectionService directly instead - Move `SelectionService` into base package. A lot of feature modules are dependent on this service => they would no longer work if the selectModule is not bound or customized
The base package should have no direct dependencies to feature module to avoid circular dependency issues.
The mouseTool is part of the default sprotty module and our customization should therefore be part of the `glspDefaultModule`. - Move mouse tool into base package - Rework `Rank` interface and utility function to our default interface+namespace pattern - Remove `TYPES.MouseTool` service identifert, and unecessary interface wrapper. Directly inject mousetool instead
martin-fleck-at
requested changes
Jul 6, 2023
|
Thanks for the fast review Martin. I have pushed an update to address the open issues. |
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Jul 9, 2023
Update code base to conform to API breaks from eclipse-glsp/glsp-client#259 Part of eclipse-glsp/glsp-client#259
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Jul 12, 2023
* GLSP-1049: Update to new client version Update code base to conform to API breaks from eclipse-glsp/glsp-client#259 Part of eclipse-glsp/glsp-client#259 * GLSP-1050: Update to Event API Requires eclipse-glsp/glsp-client#261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor base package
FeedbackActionDispatcherand related components into base packageFeedbackAwareModelCommand. RemoveModelRootChangeListenerAPI from this command and add it to the command stack instead. This ensures that the model listeners are notified after the update has been processed succeessfully. It also makes it easier to rebind theUpdateModelCommandas you don't have to consider the listeners anymore.Update to lerna 7 and fix test cases
Refactor SelectionService
SelectionServiceinto base package. A lot of feature modules are dependent on this service => they would no longer work if the selectModule is not bound or customizedMove container module out of base package
The base package should have no direct dependencies to feature module to avoid circular dependency issues.
Fixes eclipse-glsp/glsp#1049