fix: add lastUpdated Column in Transfer History (#142) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
reviewed
Nov 13, 2023
| @@ -30,6 +30,11 @@ | |||
| <td mat-cell *matCellDef="let item">{{item.state}}</td> | |||
| </ng-container> | |||
|
|
|||
| <ng-container matColumnDef="lastUpdated"> | |||
| <th mat-header-cell *matHeaderCellDef scope="col">Last updated</th> | |||
| <td mat-cell *matCellDef="let item">{{asDate(item.stateTimestamp)}}</td> | |||
There was a problem hiding this comment.
I'm quite sure that the edc-connector-client offers the stateTimestamp property on transfer process, to get that field you can use the method mandatoryValue, like: item.mandatoryValue('edc', 'stateTimestamp');, but maybe I'm wrong and it's working this way.
There was a problem hiding this comment.
Yes, you are right. I commited another change, so that now the column value is obtained as:
{{asDate(item.mandatoryValue('edc', 'stateTimestamp'))}}
This way, the column value is shown correctly.
|
you need to sign the ECA (see https://www.eclipse.org/legal/ECA.php) |
ndr-brt
approved these changes
Dec 18, 2023
farhin23
pushed a commit
to FraunhoferISST/edc-dashboard
that referenced
this pull request
Mar 5, 2024
…lipse-edc#148) * fix: add lastUpdated Column in Transfer History (eclipse-edc#142) * Get correctly stateTimestamp value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add lastUpdated column in Transfer History page
Why it does that
lastUpdated column was removed by mistake in previous commit 27f3b34 .
Linked Issue(s)
Closes #142