Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing @Priority to the AuthenticationRequestFilter #4582

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

scandinave
Copy link
Contributor

What this PR changes/adds

This PR add the jarkarta @priority annotation to the AuthenticationFilter.

Why it does that

Allow other extension to register filters in the correct order of precedence.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4580

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@paullatzelsperger
Copy link
Member

@scandinave I self-requested a review because I think you can't do that.

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Oct 24, 2024
@scandinave
Copy link
Contributor Author

scandinave commented Oct 25, 2024

@paullatzelsperger I've no idea how to test this. Add another extension juste to verify that a standard Jakarta functionality work as intented seems overkill to me. If it's ok for you I will mark the PR ready for review.

@paullatzelsperger
Copy link
Member

@paullatzelsperger I've no idea how to test this. Add another extension juste to verify that a standard Jakarta functionality work as intented seems overkill to me. If it's ok for you I will mark the PR ready for review.

Well you could theoretically spin up a test with another filter, have the auth filter return false, and assert the other filter is not invoked, but we're not testing Jakarta annotations. So, good to go!

@scandinave scandinave marked this pull request as ready for review October 25, 2024 12:51
@paullatzelsperger paullatzelsperger merged commit 476522e into eclipse-edc:main Oct 25, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuthenticationRequestFilter must define a jarkarta priority
2 participants