feat: introduces dspace namespace 2024/1 #4573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
enhancement
wolf4ood
force-pushed
the
feat/4556_introduce_2024_namespace
branch
from
aed6087
to
5c9297b
Compare
wolf4ood
force-pushed
the
feat/4556_introduce_2024_namespace
branch
from
5c9297b
to
000c0e3
Compare
wolf4ood
requested review from
ndr-brt,
ronjaquensel and
juliapampus
as code owners
wolf4ood
changed the title
paullatzelsperger
approved these changes
Oct 23, 2024
ndr-brt
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
introduces dspace namespace 2024/1
DspConstants.DSP_NAMESPACE_V_2024_1switched to2024/1namespacev08and2024/1ContinuationTokenManagerImplby passing aJsonLdNamespacefor populating thefiltertermJsonLdNamespaceconstruct variantJsonLdNamespacefor dspace.JsonObjectFromContractNegotiationTransformerwhere the type was still using the full IRI hardcoded to v08Why it does that
multi protocol support
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4556
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.