refactor: Refactor dsp messages validations into libs #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
changed the title
wolf4ood
added
refactoring
wolf4ood
force-pushed
the
refactor/4537_dsp_validation_lib
branch
from
c11da46
to
bd6d393
Compare
wolf4ood
requested review from
ndr-brt,
ronjaquensel and
juliapampus
as code owners
wolf4ood
force-pushed
the
refactor/4537_dsp_validation_lib
branch
from
e841c43
to
e42ed80
Compare
paullatzelsperger
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduces
dsp-*-validation-libone for each dsp module.Each validator can work on a provided
schema, which by default for backward compatibility isDSPACE_SCHEMA(v0.8)Relevant constants for this PR were refactor with the convention:
*_TERM: plain properties/types without namespace*_IRI: properties/types with namespace(schema +*_TERM`)This will impact other constants in future PRs as well
Why it does that
Multiple protocol versions support
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4537
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.