refactor: introduced message classes for errors #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
force-pushed
the
refactor/4536_dsp_errors_ser
branch
3 times, most recently
from
96cf363
to
653e28a
Compare
wolf4ood
requested review from
ndr-brt,
ronjaquensel and
juliapampus
as code owners
paullatzelsperger
approved these changes
Oct 14, 2024
...clipse/edc/protocol/dsp/transferprocess/transform/type/from/JsonObjectFromTransferError.java
Outdated
Show resolved
Hide resolved
...clipse/edc/protocol/dsp/transferprocess/transform/type/from/JsonObjectFromTransferError.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/types/domain/message/ErrorMessage.java
Show resolved
Hide resolved
wolf4ood
force-pushed
the
refactor/4536_dsp_errors_ser
branch
from
653e28a
to
b9e95ac
Compare
ndr-brt
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
introduced message classes for errors.
It replaces in
DspRequsttheerrorTypeinstead each controllers passes a provider/builder for building the expected error in output.Introduced classes for errors:
ErrorMessage(base class)CatalogErrorContractNegotiationErrorTransferErrorVersionsErrorIf there is an error when serving the request the
DspRequestHandlerwill create use the errorr provider to enrichit with common expected properties and then will use the versioned transformer registry for serializing the error in the correct format.
Why it does that
Multi-protocol support
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4536
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.