Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DidDocument default context #4503

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

perher
Copy link
Contributor

@perher perher commented Sep 27, 2024

What this PR changes/adds

Changes the default json-ld context for DidDocument.

Why it does that

To follow the "Decentralized Identifiers (DIDs) v1.0 specification".

Linked Issue(s)

Closes #4501

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@paullatzelsperger paullatzelsperger added the bug Something isn't working label Sep 27, 2024
@wolf4ood
Copy link
Contributor

also @perher if you rebase the PR it should fix the failing checks

Thanks

@perher
Copy link
Contributor Author

perher commented Sep 27, 2024

I've rebased and renamed constant now

Copy link

github-actions bot commented Oct 5, 2024

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Oct 5, 2024
@perher
Copy link
Contributor Author

perher commented Oct 7, 2024

rebased, but not passing the ECA check now for some reason.. will retry again later

@perher
Copy link
Contributor Author

perher commented Oct 7, 2024

updated DEPENDENCIES file

@github-actions github-actions bot removed the stale Open for x days with no activity label Oct 8, 2024
@wolf4ood
Copy link
Contributor

wolf4ood commented Oct 8, 2024

Hi @perher

seems that dependencies still failing, try to rebase from main and check it in again

Thanks

@perher
Copy link
Contributor Author

perher commented Oct 8, 2024

@wolf4ood I was already on latest main, but updated the DEPENDENCY file again according to checker

@perher
Copy link
Contributor Author

perher commented Oct 8, 2024

another dependency issue, I need help from maintainers now, please let me know what to do or feel free to push to my branch

@wolf4ood
Copy link
Contributor

wolf4ood commented Oct 8, 2024

Thanks @perher

@wolf4ood wolf4ood merged commit d6721f5 into eclipse-edc:main Oct 8, 2024
22 checks passed
@perher perher deleted the did-context-fix branch October 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected context for DID documents
3 participants