fix: catch exceptions in CompletableFutureRetryProcess #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
force-pushed
the
4464-catch-exceptions
branch
from
d2c672c
to
9dab4bf
Compare
wolf4ood
approved these changes
Sep 16, 2024
ndr-brt
added a commit
to Think-iT-Labs/edc-connector
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Catches exceptions that could happen in the
CompletableFutureRetryProcessWhy it does that
avoid state machine entry to stale
Further notes
AzureStorageDataSinkFactory). having the overarching component to handle it safely it is a new feature to the state machine retry process component that will prevent such potential bugs downstream.StatusResultRetryProcess, that was treating the throwable as a "fatal error", but in fact it is better to consider it a generic failure because the exception could be temporaryLinked Issue(s)
Closes #4464
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.