Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dsp): support implicit Offer policy type #4143

Merged

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Apr 29, 2024

What this PR changes/adds

Set "Offer" as implicit policy type on JsonObjectToContractOfferMessageTransformer

Why it does that

because it's not mandatory in the dspace:offer type

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes #4118

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt added enhancement New feature or request dataspace-protocol related to the dataspace protocol labels Apr 29, 2024
@ndr-brt ndr-brt requested a review from jimmarino April 29, 2024 12:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (7f20ba5) to head (fe37283).
Report is 231 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4143      +/-   ##
==========================================
+ Coverage   71.74%   74.88%   +3.13%     
==========================================
  Files         919      986      +67     
  Lines       18457    20262    +1805     
  Branches     1037     1143     +106     
==========================================
+ Hits        13242    15173    +1931     
+ Misses       4756     4589     -167     
- Partials      459      500      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt ndr-brt force-pushed the 4118-support-implicit-offer-type branch from 5ff04f1 to fe37283 Compare April 29, 2024 13:16
@ndr-brt ndr-brt merged commit 0aee8ef into eclipse-edc:main Apr 30, 2024
16 checks passed
@ndr-brt ndr-brt deleted the 4118-support-implicit-offer-type branch April 30, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support implict Offer policy type for DSP messages
3 participants