Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected context for DID documents #4501

Closed
perher opened this issue Sep 26, 2024 · 3 comments · Fixed by #4503
Closed

Unexpected context for DID documents #4501

perher opened this issue Sep 26, 2024 · 3 comments · Fixed by #4503
Labels
bug Something isn't working

Comments

@perher
Copy link
Contributor

perher commented Sep 26, 2024

Bug Report

Describe the Bug

When performing a did:web resolution call towards Identity Hub it returns a DID document with https://w3id.org/did-resolution/v1 context but expected it to be: https://www.w3.org/ns/did/v1.

Expected Behavior

When returning a DID document it is expected that it follows the Decentralized Identifiers (DIDs) v1.0 specification.

Observed Behavior

The current https://w3id.org/did-resolution/v1 context as specified https://github.com/eclipse-edc/Connector/blob/main/spi/common/identity-did-spi/src/main/java/org/eclipse/edc/iam/did/spi/document/DidDocument.java#L31 is for "Decentralized Identifier Resolution (DID Resolution)" see https://w3c.github.io/did-resolution/#example

Steps to Reproduce

  1. Start MVD sample
  2. Query did document with curl http://localhost:7093/.well-known/did.json.
  3. Observe that following document is returned
{
  "service": [
    {
      "id": "provider-credentialservice-1",
      "type": "CredentialService",
      "serviceEndpoint": "http://localhost:7091/api/presentation/v1/participants/ZGlkOndlYjpsb2NhbGhvc3QlM0E3MDkz"
    },
    {
      "id": "provider-catalogserver-dsp",
      "type": "ProtocolEndpoint",
      "serviceEndpoint": "http://localhost:8092/api/dsp"
    }
  ],
  "verificationMethod": [
    ...
  ],
  "authentication": [],
  "id": "did:web:localhost%3A7093",
  "@context": [
    "https://w3id.org/did-resolution/v1"
  ]
}

Context Information

EDC version 0.10.0-SNAPSHOT

@github-actions github-actions bot added the triage all new issues awaiting classification label Sep 26, 2024
Copy link

Thanks for your contribution 🔥 We will take a look asap 🚀

@paullatzelsperger
Copy link
Member

@perher thanks for reporting. Do you want to create a PR for this?

@paullatzelsperger paullatzelsperger added bug Something isn't working and removed triage all new issues awaiting classification labels Sep 26, 2024
@perher
Copy link
Contributor Author

perher commented Sep 27, 2024

sure, I created a PR for this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants