Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): request new ORG-level secrets #5

Merged

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Sep 25, 2023

What this PR changes/adds

This PR adds two new org-level secrets, the GITHUB_BOT_TOKEN and the GITHUB_BOT_USER. Those secrets already exist on our Jenkins instance (named BOTTOKEN and BOT), so we would simply like to migrate them to GitHub.

Why it does that

We would like to be able to invoke workflows across repos, so e.g. our Release repo invokes a test workflow in the Connector repo. For that we need a PAT on the ORG level.

Further notes

  • I was unable to deduce the exact path in the secrets manager, so I put ??????? there. Please advise, and I will amend my PR.
  • AFAIK, it is possible to use a PAT instead of a user/password combo. So theoretically, a GITHUB_BOT_TOKEN (containing the bot's PAT) should be sufficient. I have no preference either way.
  • unrelated: I added a .gitignore file

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@github-actions

This comment has been minimized.

Signed-off-by: Thomas Neidhart <[email protected]>
Signed-off-by: Thomas Neidhart <[email protected]>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Signed-off-by: Thomas Neidhart <[email protected]>
@github-actions
Copy link

Diff for 1f3bc65:
Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization eclipse-edc[id=eclipse-edc]
  there have been 58 validation infos, enable verbose output with '-v' to to display them.

+   add org_secret[name="ORG_GITHUB_BOT_TOKEN"] {
+     name                                                     = "ORG_GITHUB_BOT_TOKEN"
+     selected_repositories                                    = []
+     visibility                                               = "public"
+   }

+   add org_secret[name="ORG_GITHUB_BOT_USER"] {
+     name                                                     = "ORG_GITHUB_BOT_USER"
+     selected_repositories                                    = []
+     visibility                                               = "public"
+   }
  
  Plan: 2 to add, 0 to change, 0 to delete.
Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization eclipse-edc[id=eclipse-edc]

@netomi netomi merged commit c586164 into eclipse-edc:main Sep 25, 2023
2 checks passed
@netomi
Copy link
Contributor

netomi commented Sep 25, 2023

secrets have been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants