Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API & template changes to get rid of addReturnObject method #395

Merged
merged 4 commits into from
May 28, 2020
Merged

API & template changes to get rid of addReturnObject method #395

merged 4 commits into from
May 28, 2020

Conversation

rakshitkr
Copy link
Contributor

@rakshitkr rakshitkr commented May 14, 2020 •
edited
Loading

Description

This PR contain changes to get rid of addReturnObject method in the code generation templates

Fixes #342

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • tested & verified encryption.SecureEncryptor with previously generated code
  • tested all main options in code generation wizard

Test Configuration:

  • Eclipse Version: 2020-03
  • Java Version: 1.8
  • OS: Mac Catalina

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rakshitkr
Removed addReturnObject from the API
f5206e3 
Signed-off-by: Rakshit Krishnappa Ravi <[email protected]>

- was quite indirect and hard to wrap one's head around
- replaced with addParameter, which links a variable from the glue code with a variable from the respective CrySL rule
@rakshitkr
Replaced addReturnObject with addParameter calls
aea846b 
Signed-off-by: Rakshit Krishnappa Ravi <[email protected]>

- addReturnObject(a) replaced with calls to addParameter(a, retVarInCrySLRule) to accomodate new changes in API
@rakshitkr
Delete org.eclipse.m2e.core.prefs
daa40ea 
Signed-off-by: Rakshit Krishnappa Ravi <[email protected]>

- this was accidentally added in previous commit
@rakshitkr rakshitkr changed the title Fix/issue 342 API & template changes to get rid of addReturnObject method May 14, 2020
@kruegers kruegers self-requested a review May 14, 2020 12:22
@kruegers kruegers merged commit c1c9c9a into eclipse-cognicrypt:develop May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruegers kruegers kruegers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakshitkr @kruegers