Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for programmatic columns UI/UX #843

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoangphamEclipse
Copy link
Contributor

@hoangphamEclipse hoangphamEclipse commented Sep 29, 2022

This commit adds an ADR that contains the proposal for a UI/UX desgin for programmatic columns in the Theia Trace Extension.

You can view the well rendered ADR here.

Signed-off-by: Hoang Thuan Pham [email protected]

This commit adds an ADR that contains the proposal for a UI/UX
desgin for programmatic columns in the Theia Trace Extension.

Signed-off-by: Hoang Thuan Pham <[email protected]>
@jonahgraham
Copy link
Contributor

This looks really interesting and a welcome addition. I have some questions, but they aren't mean't to holdup the first steps as many of them may simply be considered longer term considerations.

  • Can you reference previous/next state in the calculation? To expand on the example in the proposal, if I have a column of timestamps, can I have a calculated column showing duration that subtracts the previous row's timestamp from this row's one?
  • Does the calculation happen on the client side or the server side?
  • Can you visualize (graph) the new columns?

As I found the diff version a little hard to read (And others may too) here is a link back to the originating branch where the markdown is well rendered with images and all. If there is a GitHub trick to see that from the PR directly let me know.

@hoangphamEclipse
Copy link
Contributor Author

Hi @jonahgraham, thank you for your feedback. I will get @MatthewKhouzam or @bhufmann to join in this conversation because some questions are better answered by them.

  • Can you reference previous/next state in the calculation? To expand on the example in the proposal, if I have a column of timestamps, can I have a calculated column showing duration that subtracts the previous row's timestamp from this row's one?
  • Can you visualize (graph) the new columns?

These were not original requirements for this ADR, but it is interesting. I will let Bernd or Matthew give their opinion on this.

  • Does the calculation happen on the client side or the server side?

The calculation will be on the server side.

As I found the diff version a little hard to read (And others may too) here is a link back to the originating branch where the markdown is well rendered with images and all. If there is a GitHub trick to see that from the PR directly let me know.

Thank you for noticing this, I will put the link to the well rendered ADR in the PR description so that it will be easier for others to view it.

@MatthewKhouzam
Copy link
Contributor

Hi @jonahgraham, thank you for your feedback. I will get @MatthewKhouzam or @bhufmann to join in this conversation because some questions are better answered by them.

   Can you reference previous/next state in the calculation? To expand on the example in the proposal, if I have a column of timestamps, can I have a calculated column showing duration that subtracts the previous row's timestamp from this row's one?

We had this in mind with the caveat that filtering messes this up. So we put it off for "later"
I really like (time - time') as a column

   Can you visualize (graph) the new columns?

That is the next logical and soon to be published step! :)

@marco-miller marco-miller marked this pull request as draft January 25, 2023 14:00
@bhufmann
Copy link
Collaborator

bhufmann commented Mar 1, 2023

What is the plan of this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants