Enhance internal decoder performance #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
|
@timj here is a compilation of my efforts to improve the internal decoder's speed. I decided to make them separate from #17 as they are related, but also this can be merged in advance. Let me know if you observe any issues with PGS or VobSub with these changes. I think I didn't break anything but it's always good to check. |
Signed-off-by: Ethan Dye <[email protected]>
This also add proper attribution for the source of the test files. Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
|
The internal decoder is much much faster. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the performance of the internal decoder significantly
by taking advantage of unsafe pointers in Swift to reduce the memory
overhead and processing time for decoding input files. This also adds
compatibility that is needed in order to move forward with #17.