Fix decoding of VobSub for different RLE offsets #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix any issues that could occur due to the data being offset from the typical 0 in the RLE buffer. However this has not been tested against a large number of subtitles, so there may be some cases where it either breaks decoding or doesn't properly interact with various RLE offsets. Fixes #19 Signed-off-by: Ethan Dye <[email protected]>
Signed-off-by: Ethan Dye <[email protected]>
|
That definitely fixed my interlaced VOBSUB file. Looks beautiful now. I tried a different interlaced file and it was fine and non-interlaced do work still. I can try to find some more examples another day but this is a genuine enhancement that makes me very happy. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix any issues that could occur due to the data being offset from the typical 0 in the RLE buffer. However this has not been tested against a large number of subtitles, so there may be some cases where it either breaks decoding or doesn't properly interact with various RLE offsets.
Fixes #19