Continue refactoring ProfileImportModal to eventually separate business logic from UI #1477
+58
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid unnecessary non-null assertions as that's a bad habit. Throw an error if components local state is invalid before starting the import.
This makes the code easier to read and might make it easier to refactor the profileCreatedCallback further.
Profiles imported as code are always .r2z files. Previously user could choose the older .r2x format when importing profile from a file, but support for this was dropped recently, and only .r2z is supported now.
As a bonus this now handless the unlikely error properly instead of just ignoring it silently.
This requires slight changes to addEventListener, but these changes are probably an improvements by themselves.
- Earlier step has checked there's importable mods in the profile - Download provider has another, less user-friendly check for the same thing to prevent the mod profile from getting stuck - It doesn't seem anything catastrophic would happen even if the rest of the code is executed using an empty mod list
I don't see any reason for to wrap the code in the timeout. This might have been relevant when the import step was started right away after a new profile was created, by there now exists a preview window between these steps so the folder should always exists. If it doesn't, the 100ms wait won't change things.
VilppeRiskidev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.