Separate parseYamlToExportFormat function from ImportProfileModal UI … #1451
+45
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
requested changes
Sep 23, 2024
VilppeRiskidev
force-pushed
the
separate-parse-yaml-from-component
branch
from
6690cde
to
b389e76
Compare
anttimaki
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
@VilppeRiskidev the PR is approved, but unlike we agreed earlier, I won't merge it yet. This is because Mythic wants to keep the "release pipeline clean" this week in case we need to do a hotfix update. So chain the next PR on this branch instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…component