Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watching online mod list for changes #1439

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

anttimaki
Copy link
Collaborator

Online mod list was watching a wrong variable, and wouldn't fire an autoupdate if the main mod list changed, i.e. if there was a background update from Thunderstore API while user had the online mod list open.

This was broken some 6 months ago by yours truly while moving the mod list into Vuex store.

Online mod list was watching a wrong variable, and wouldn't fire an
autoupdate if the main mod list changed, i.e. if there was a background
update from Thunderstore API while user had the online mod list open.

This was broken some 6 months ago by yours truly while moving the mod
list into Vuex store.
Copy link
Collaborator

@VilppeRiskidev VilppeRiskidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@anttimaki anttimaki merged commit 232551a into develop Sep 17, 2024
5 of 7 checks passed
@anttimaki anttimaki deleted the fix-online-modlist-watching branch September 17, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants