Reset Vuex state when returning to game selection to free up memory #1385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
reviewed
Jun 27, 2024
There was a problem hiding this comment.
I'm not sure what "start resetting" in the PR title refers to, but yes, this looks like a good beginning of what I had in mind. However, if you check the ticket, my original idea was to call a reset method on the main/index store, and let it handle resetting the substores. Is there a reason why this now directly calls reset on profile substore? Are you planning adding the resets of the other stores in this PR or a separate one?
VilppeRiskidev
force-pushed
the
reset-profile-data-on-game-selection-screen
branch
from
1dafecf
to
fc95df9
Compare
anttimaki
reviewed
Aug 21, 2024
VilppeRiskidev
force-pushed
the
reset-profile-data-on-game-selection-screen
branch
2 times, most recently
from
bd9342e
to
5aa8b0e
Compare
anttimaki
requested changes
Sep 10, 2024
VilppeRiskidev
force-pushed
the
reset-profile-data-on-game-selection-screen
branch
from
5aa8b0e
to
03e2f40
Compare
|
I'll approve this PR when #1410 is approved. |
…onScreen is created
VilppeRiskidev
force-pushed
the
reset-profile-data-on-game-selection-screen
branch
from
03e2f40
to
762be48
Compare
…in page components
There was still a bug where returning to profile selections screen and then moving back to manager screen with the same profile (without changing the active profile in between) displayed an empty local mod list. Also if the TsModsModule can't be reset here, it somewhat waters down the another half of the purpose of these changes, which was to free up memory when it's not needed. The things that would have gotten reset are very small compared to the large mod lists. Full resetting is still done if the active game is changed.
Add data resetting to vuex storage modules and use the functionality in page components
anttimaki
approved these changes
Sep 26, 2024
anttimaki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.