Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max min seq sub #265

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Max min seq sub #265

wants to merge 5 commits into from

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Oct 14, 2024

Purpose

A user attempted to align ~1K sequences but couldn't click the submission button (because it exceeded the current limit of 50) and did not understand why. This PR will make it clearer to the user about min/max number of sequences.

Approach

Update SequenceSubmission to accept optional minimumSequences and maximumSequences props which if they exist will check if user sequences are within bounds and if not display an error (rather than info) message. Otherwise default to info message with number of sequences.

Testing

Updated

Stories

Updated

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why
  • Were all the edited/created files in TypeScript? If not, please list the files you left in JavaScript and the reason to not update them.
  • For the stories you created/updated, are the props modifiables through knobs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants