Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use custom logger instead of logging #44

Closed
wants to merge 2 commits into from
Closed

use custom logger instead of logging #44

wants to merge 2 commits into from

Conversation

hit9
Copy link

@hit9 hit9 commented Mar 17, 2014

Previous pull raised a warning, this one fixed it.

@earl
Copy link
Owner

earl commented Jun 22, 2014

Thanks for the suggestion.

To be honest, this particular failure mode (logging an error but continuing operation) has bugged me basically from the day I introduced it. I'm now convinced, that this behaviour is a bad idea, and instead of changing the logger usage, I'd rather fix the whole failure model.

So I won't merge this PR, but will open a separate issue (#49) to gather feedback on the behavioural change. Once the failure mode is fixed, the use of logging will be gone altogether.

@earl earl closed this Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants