Skip to content

Commit

Permalink
[hotfix] disable XML signature validation until crypto-lib issues res…
Browse files Browse the repository at this point in the history
…olved
  • Loading branch information
Olaf Schreck committed Jun 25, 2021
1 parent a250059 commit 9c43d19
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
4 changes: 3 additions & 1 deletion RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@

# Current Version

Version 1.6.2 (Jun 25 2021)
Version 1.6.3 (Jun 25 2021)

## New Features

## Fixes and Improvements

* [bugfix] add missing doc to set password for user exsaml
* [hotfix] disable XML signature validation until crypto-lib issues resolved
Code that references a currently undefined crypto-lib function commented out
2 changes: 1 addition & 1 deletion VERSION.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.6.2
1.6.3
2 changes: 1 addition & 1 deletion build.properties.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<app>
<name>existdb-saml</name>
<description>SAML implementation for existdb</description>
<version>1.6.2</version>
<version>1.6.3</version>
<url>http://exist-db.org/xquery/exsaml</url>
<status>beta</status>
<permissions>rwxr-xr-x</permissions>
Expand Down
10 changes: 6 additions & 4 deletions content/exsaml.xqm
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,9 @@ declare %private function exsaml:validate-saml-response($resp as node()) {
)

(: verify response signature if present :)
else if (boolean($sig) and not(exsaml:verify-response-signature($sig))) then
<exsaml:funcret res="-4" msg="failed to verify response signature" />
(: COMMENTED OUT until crypto-lib issues resolved :)
(: else if (boolean($sig) and not(exsaml:verify-response-signature($sig))) then :)
(: <exsaml:funcret res="-4" msg="failed to verify response signature" /> :)

(: must contain at least one assertion :)
else if (empty($as)) then (
Expand Down Expand Up @@ -313,8 +314,9 @@ declare %private function exsaml:validate-saml-assertion($assertion as item()) {
)

(: verify assertion signature if present :)
else if (boolean($sig) and not(exsaml:verify-assertion-signature($assertion))) then
<exsaml:funcret res="-10" msg="failed to verify assertion signature" />
(: COMMENTED OUT until crypto-lib issues resolved :)
(: else if (boolean($sig) and not(exsaml:verify-assertion-signature($assertion))) then :)
(: <exsaml:funcret res="-10" msg="failed to verify assertion signature" /> :)

(: maybe verify SubjectConfirmation/@Method :)

Expand Down

0 comments on commit 9c43d19

Please sign in to comment.