-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file-preview-card-group): add class for card description #2465
base: master
Are you sure you want to change the base?
Conversation
|
After some discussion offline, I ended up doing kind of a major refactor of the way that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A couple of minor comments.
The rest (naming convention) we'll discuss "offline."
@@ -8,22 +8,20 @@ | |||
<h3>Uploading File Preview Card</h3> | |||
<div class="demo"> | |||
<div class="demo__inner"> | |||
<div style="height: 168px; width: 168px;"> | |||
<div style="width: 168px"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this width needed? I know it was here before but shouldn't we have sizes based on the grid for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an arbitrary width just for the example. The container of the component is what decides its width
@@ -10,7 +15,7 @@ | |||
); | |||
box-sizing: border-box; | |||
display: grid; | |||
grid-template-areas: " . . menu-action " " . center-action . " " label . . "; | |||
grid-template-areas: " . . action " " . counter . " " signal . . "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to stick with grid or go to using position absolute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just switched to absolute positioning, I'll change some names and then we should be ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job on the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for bearing with us. 😃
Just add a changeset and check all the items off from the dev checklist.
Let's run a targeted Percy build too since this was out already to ensure visual consistency.
Description
file-preview-card
withinfile-preview-card-group
Screenshots
Checklist