Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-input): new component #2288

Open
wants to merge 2 commits into
base: 14.4.0
Choose a base branch
from
Open

feat(file-input): new component #2288

wants to merge 2 commits into from

Conversation

LuLaValva
Copy link
Member

Description

  • Create ebay-file-input component

Screenshots

image

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 2180ad7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just one minor comment and I think its ready to merge

handleFileChange(event: Event) {
const target = event.target as HTMLInputElement;
this.emit("input", { files: target.files, originalEvent: event });
target.value = "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, I think we dont need it.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agliga
Copy link
Contributor

agliga commented Oct 18, 2024

@LuLaValva Once we remove that value = "" code, this should be ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants