Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup (Public-dash) #1 - Tasks: A-2, 6, 7, 8 #153

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Sep 21, 2024

  1. Task A-6: Switching to step outputs instead of GITHUB_ENV

    Refer to details in cleanup issue:
    Task A-6: e-mission/e-mission-docs#1082 (comment)
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    fb2b096 View commit details
    Browse the repository at this point in the history
  2. Task A-2: Storing latest tag in .env file + Read raw .env file

    Refer to details in cleanup issue:
    Task A-2: e-mission/e-mission-docs#1082 (comment)
    
    Added .env file initialized with the current latest tag of admin-dash and server image.
    Internal script can read docker image tags directly from .env.tags using curl to fetch raw file contents.
    Storing server tag as well since admin-dash Dockerfile uses it.
    
    Removed workflow dispatch inputs
    No longer need inputs since reading from .env.tags in server repo directly
    
    ------
    
    Read raw file contents directly instead of using REST API
    REST API endpoint returns base64 encoded data which then needs to be decoded.
    Can simply read the Raw file contents from the publicly available file.
    
    ------
    
    Also changed tag name to match tag name in internal repository
    This way we can directly use the tag name without having extra fields like envVar in the internal script.
    
    -----
    
    For now not removing artifacts until the internal script is updated to handle this change.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    1446a3a View commit details
    Browse the repository at this point in the history
  3. Task A-8: Prefix branch name + Task A-7: Removed certificates from ex…

    …ternal
    
    Task A-8: Prefixing branch name to the docker tag along with the date.
    In the internal script we will not need to maintain the different branch lists as the images will be completely tagged in the external workflows themselves.
    We can simply use the tags without modifications then.
    
    For now, not prefixing the tag to the artifact since we will be removing the artifact anyways.
    And current internal script works with artifacts.
    Once I update the internal script, will come back and remove artifacts.
    Also removing prefixed branch name from frontend image artifact in case of workflow dispatch event since it uses the existing frontend image tag generated during push event which already has prefixed branch name
    
    In Dockerfile, removing hardcoded branch name, since in this change, we are already included the branch name in image tag.
    
    ----------
    
    Task A-7: Certifcates added to internal Dockerfiles.
    
    Refer to issue comment for details:
    Task A-7: e-mission/e-mission-docs#1082 (comment)
    
    The certificates are relevant to our internal AWS configuration and not needed externally.
    They can be present externally too without having any major effect.
    But removing them helps keeping the base image clean.
    Additionally, anyone working with the code can customize with their own certificates if needed or adopt an approach which doesn't even need certificates in the first place.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    2c7460e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Task A-2: Removed artifact upload ; internal script updated

    Internal script updated as well.
    Internal PR must be merged as well once these external PR changes merged.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    d799254 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Configuration menu
    Copy the full SHA
    490940f View commit details
    Browse the repository at this point in the history