Editable mode & purpose confirm #508
Conversation
|
Can one of the admins verify this patch? |
|
@atton16 Your only commit 3e0afe3 basically includes html file changes alone (it looks like you add a second button in addition to the one that @sunil07t had already added to open the mode and purpose popovers). However, this does not address the primary issue with the previous PR, namely that it will ONLY pull data from the usercache ( I highlighted this in the issue (https://github.com/e-mission/e-mission-phone/issues/503#issuecomment-443484106) and suggested how to fix it; however, I don't see the fix in your commit. Did you test this with server pushes? Can you please fill out the testing done, along with screenshots of the change? Similar to the initial PR (#307). |
|
I should clarify that I am not opposed to merging this as an intermediate step as long as you make the final changes later. But I just want to clarify that as far as I can see, this will not be a complete fix. For example, if you confirm your trips on the 2nd, and go back to them on the 4th, with this PR, you will not see the confirmed mode and purpose. |
|
We knows this limitation and we are working on it. The reason that we did not use the |
https://github.com/e-mission/e-mission-phone/blob/master/www/js/services.js#L232 |
ok, I am merging this for now. @asiripanich, bewarned while testing... |
|
@atton16 @asiripanich deployed, should be live in ~ 10-20 mins |
|
@shankari Thanks heaps! |
No description provided.