feat: Add vault functions for native/mobile #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # v4-client-js/__native__/__ios__/v4-native-client.js
ruixhuang
changed the title
rosepuppy
reviewed
Sep 26, 2024
| } | ||
|
|
||
| export async function depositToMegavault( | ||
| subaccountNumber: number, |
There was a problem hiding this comment.
I thought we need to decode the payload for params?
There was a problem hiding this comment.
We use the encoded payload when calling v4-client functions from Abacus. In this case, we will call those functions from the mobile client directly instead of having Abacus calling it.
getMegavaultOwnerShares will be called from Abacus, so it's using payload string.
ruixhuang
changed the title
rosepuppy
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.