Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for timestamp nonce #255

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat: support for timestamp nonce #255

merged 4 commits into from
Sep 26, 2024

Conversation

aforaleka
Copy link
Contributor

  • account sequence number can soon be replaced by timestamp
  • this eliminates the need to to fetch account sequence number from account as part of tx options
  • adding a flag / config param since this isn't completely out yet

testing:

  • tested locally / breakpoints that transactions work, and no unnecessary fetch to account for placing stateful orders

@aforaleka aforaleka marked this pull request as ready for review September 25, 2024 20:17
@aforaleka aforaleka changed the base branch from pre-populate-account-number-cache to main September 25, 2024 20:35
@aforaleka aforaleka enabled auto-merge (squash) September 26, 2024 18:45
@aforaleka aforaleka merged commit dcdd233 into main Sep 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddyding teddyding teddyding left review comments

@jayy04 jayy04 jayy04 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aforaleka @teddyding @jayy04