-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return undefined for candles orderbookMidPrice instead of hitting OrderbookCache in Redis #2438
Conversation
Co-authored-by: dydxwill <[email protected]>
Co-authored-by: Adam Fraser <[email protected]>
Co-authored-by: Christopher-Li <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
) Co-authored-by: dydxwill <[email protected]>
…ics (backport #2131) (#2164) Co-authored-by: jerryfan01234 <[email protected]>
Co-authored-by: jerryfan01234 <[email protected]> Co-authored-by: Jerry Fan <[email protected]>
Co-authored-by: Jerry Fan <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
…2224) (#2226) Co-authored-by: roy-dydx <[email protected]>
…(backport #2244) (#2245) Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: dydxwill <[email protected]> Co-authored-by: Will Liu <[email protected]>
…eposit (backport #2330) (#2339) Co-authored-by: jerryfan01234 <[email protected]> Co-authored-by: Jerry Fan <[email protected]>
Co-authored-by: dydxwill <[email protected]> Co-authored-by: Will Liu <[email protected]>
…#2368) (#2373) Co-authored-by: dydxwill <[email protected]>
Co-authored-by: dydxwill <[email protected]>
Co-authored-by: dydxwill <[email protected]>
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ce4d4f4
to
6c2107b
Compare
6c2107b
to
8892624
Compare
Changelist
Removes code that hits the OrderbookCache when generating candles. This change will be fixed in a later update