Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kafka docker version 2.6 -> 3.5.1 #2156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade kafka docker version 2.6 -> 3.5.1 #2156

wants to merge 1 commit into from

Conversation

jiajames
Copy link
Contributor

@jiajames jiajames commented Aug 26, 2024 •
edited by coderabbitai bot
Loading

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Upgraded Kafka service to version 3.5.1 across various deployment configurations, enhancing performance, features, and security.

  • Bug Fixes

    • Transition to a new Kafka image provider may resolve existing issues and improve compatibility.

  • Documentation

    • Updated Docker Compose configurations to reflect changes in the Kafka image, ensuring clarity in deployment setups.

@jiajames jiajames requested a review from a team as a code owner August 26, 2024 19:13
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 26, 2024 •
edited
Loading

Walkthrough

The changes involve updating the Docker image used for the Kafka service across multiple GitHub Actions workflow files and Docker Compose configuration files. The image has been changed from blacktop/kafka:2.6 to bitnami/kafka:3.5.1, reflecting an upgrade to a more recent version of Kafka.

Changes

Files Change Summary
.github/workflows/indexer-reusable-build-and-run-and-run-docker-image.yml, .github/workflows/indexer-reusable-build-and-run-with-pg-redis-kafka.yml, e2e-testing/docker-compose-e2e-test.yml, indexer/docker-compose-local-deployment.yml, indexer/docker-compose.yml Updated Kafka image from blacktop/kafka:2.6 to bitnami/kafka:3.5.1 for all listed files.
protocol/indexer/msgsender/msgsender_kafka_integration_test.go Changed Docker image from blacktop/kafka:2.6 to bitnami/kafka:3.5.1.

Sequence Diagram(s)

sequenceDiagram
    participant CI as CI/CD Pipeline
    participant Kafka as Kafka Service
    CI->>Kafka: Start using bitnami/kafka:3.5.1
    Kafka-->>CI: Kafka service running with new image
Loading

🐰 "Oh, the code is hopping with glee,
A new Kafka image, oh what a spree!
From blacktop to bitnami, we leap,
In workflows and tests, our changes run deep.
So let's celebrate, with a joyful cheer,
For smoother deployments, the future is near!" 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3b57212 and 5440586.

Files selected for processing (6)
  • .github/workflows/indexer-reusable-build-and-run-docker-image.yml (1 hunks)
  • .github/workflows/indexer-reusable-build-and-run-with-pg-redis-kafka.yml (1 hunks)
  • e2e-testing/docker-compose-e2e-test.yml (1 hunks)
  • indexer/docker-compose-local-deployment.yml (1 hunks)
  • indexer/docker-compose.yml (1 hunks)
  • protocol/indexer/msgsender/msgsender_kafka_integration_test.go (1 hunks)
Additional comments not posted (7)
indexer/docker-compose.yml (1)

4-4: Verify compatibility and configuration options with the new Kafka image.

The Kafka Docker image has been updated from blacktop/kafka:2.6 to bitnami/kafka:3.5.1. Ensure that the new image is compatible with your existing setup and review the configuration options for any changes.

Run the following script to verify the configuration options for the new Kafka image:

.github/workflows/indexer-reusable-build-and-run-with-pg-redis-kafka.yml (1)

29-29: Verify compatibility and configuration options with the new Kafka image.

The Kafka Docker image has been updated from blacktop/kafka:2.6 to bitnami/kafka:3.5.1. Ensure that the new image is compatible with your existing setup and review the configuration options for any changes.

Run the following script to verify the configuration options for the new Kafka image:

.github/workflows/indexer-reusable-build-and-run-docker-image.yml (1)

30-30: Verify compatibility and configuration options with the new Kafka image.

The Kafka Docker image has been updated from blacktop/kafka:2.6 to bitnami/kafka:3.5.1. Ensure that the new image is compatible with your existing setup and review the configuration options for any changes.

Run the following script to verify the configuration options for the new Kafka image:

protocol/indexer/msgsender/msgsender_kafka_integration_test.go (2)

47-47: LGTM!

The repository for the Kafka Docker image has been correctly updated to bitnami/kafka.

The code change is approved.

48-48: LGTM!

The tag for the Kafka Docker image has been correctly updated to 3.5.1.

The code change is approved.

indexer/docker-compose-local-deployment.yml (1)

4-4: LGTM!

The image for the Kafka service has been correctly updated to bitnami/kafka:3.5.1.

The code change is approved.

e2e-testing/docker-compose-e2e-test.yml (1)

4-4: LGTM!

The image for the Kafka service has been correctly updated to bitnami/kafka:3.5.1.

The code change is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
indexer protocol
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiajames