Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Removed remaining modal, backdrop elements on closeModal function #224

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaeljymsgutierrez
Copy link

@michaeljymsgutierrez michaeljymsgutierrez commented Oct 12, 2017

Added total removal of elements on modal from DOM.
In some situation the closeModal function didn't remove all modal elements instead there are some remaining on DOM especially the backdrop and multiple creation of modal when used on same controller with others.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 83.908% when pulling a825acc on michaeljymsgutierrez:remove-remaining-modal-elements-onclose into 2db21c5 on dwmkerr:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 85.393% when pulling efe663d on michaeljymsgutierrez:remove-remaining-modal-elements-onclose into 2db21c5 on dwmkerr:master.

@dwmkerr
Copy link
Owner

dwmkerr commented Oct 30, 2017

Looks good to me, although the library is not bootstrap specific and this assumes the modals are bootstrap modals, any thoughts on how we can keep it generic?

@michaeljymsgutierrez
Copy link
Author

Yeah but, for some reason most used library for modal system is bootstrap modal ?
with same classes used.I think it is generic for now. And in what I have encounter using your awesome library, this fixed save my day.

@dwmkerr
Copy link
Owner

dwmkerr commented Nov 8, 2017

What about adding a flag to the options, perhaps a boolean called something like bootstrap, and then if the flag is present we can do the angular specific cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants