Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate Wiki Publish - Issue #241 #242

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Automate Wiki Publish - Issue #241 #242

merged 1 commit into from
Jul 16, 2020

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Jul 4, 2020 •
edited
Loading

Pull Request (PR) description

Automate publishing of Wiki content.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - could you review when you have a moment?

This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Jul 4, 2020
johlju
johlju approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju
Copy link
Member

johlju commented Jul 4, 2020

PR looks good. I think the tests fail on something else.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jul 4, 2020
@PlagueHO
Copy link
Member Author

PlagueHO commented Jul 7, 2020

Thanks @johlju - I have an issue open to work on the reliability of these tests in WS 2019. #240

Looks like I'll need to get that through before this PR can be finished.

@PlagueHO PlagueHO mentioned this pull request Jul 16, 2020
Open
@PlagueHO PlagueHO closed this Jul 16, 2020
@PlagueHO PlagueHO reopened this Jul 16, 2020
@PlagueHO PlagueHO merged commit 4b2d4ae into dsccommunity:master Jul 16, 2020
@PlagueHO PlagueHO deleted the Issue-241 branch July 16, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Automated Documentation Publish to Wiki in Deployment
2 participants
@PlagueHO @johlju