Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines revamp (reading and writing) #7

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Jan 20, 2022

  1. Require 'english' throughout, to define $INPUT_RECORD_SEPARATOR

    It was only required for the MemoryFileSystem,
    not the real FileSystem, so writing an array would concatenate all
    the lines together without any spaces or newlines.
    cllns committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    a7ff007 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Fix newlines on reading and writing

    Specifically, we don't want to *join* the lines, but rather append to each line.
    This lets us avoid having to manually add a newline to the end, and handle them all at once.
    
    Also, we chomp every line on read (and before write) so we don't duplicate any newlines
    cllns committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    fbfaed8 View commit details
    Browse the repository at this point in the history
  2. Chomp lines for MemoryFileSystem#readline

    This is so when they're read out, they do not contain line breaks at the end of each line's string. Later on, when this content is passed to write, it is joined with , which will add newlines
    radar authored and cllns committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    b4e7106 View commit details
    Browse the repository at this point in the history
  3. Change file system adapters to only write Strings

    This separates the concerns, so the adapters only write **String**s,
    they don't do any joining or coercion.
    cllns committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    182c874 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6a5f92d View commit details
    Browse the repository at this point in the history
  5. Fix style guide violations

    cllns committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f1f4389 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d456998 View commit details
    Browse the repository at this point in the history
  7. Remove unnecessary chomp

    cllns committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8d4dbc3 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Configuration menu
    Copy the full SHA
    bcbac68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c5053c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    c8fa3d9 View commit details
    Browse the repository at this point in the history
  2. Fix typo

    cllns committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d4d36fc View commit details
    Browse the repository at this point in the history
  3. Capitalize name of file

    cllns committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d873b27 View commit details
    Browse the repository at this point in the history