-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newlines revamp (reading and writing) #7
Open
cllns
wants to merge
13
commits into
dry-rb:main
Choose a base branch
from
cllns:readline-chomp-redux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 20, 2022
-
Require 'english' throughout, to define $INPUT_RECORD_SEPARATOR
It was only required for the MemoryFileSystem, not the real FileSystem, so writing an array would concatenate all the lines together without any spaces or newlines.
Configuration menu - View commit details
-
Copy full SHA for a7ff007 - Browse repository at this point
Copy the full SHA a7ff007View commit details
Commits on Jan 21, 2022
-
Fix newlines on reading and writing
Specifically, we don't want to *join* the lines, but rather append to each line. This lets us avoid having to manually add a newline to the end, and handle them all at once. Also, we chomp every line on read (and before write) so we don't duplicate any newlines
Configuration menu - View commit details
-
Copy full SHA for fbfaed8 - Browse repository at this point
Copy the full SHA fbfaed8View commit details -
Chomp lines for MemoryFileSystem#readline
This is so when they're read out, they do not contain line breaks at the end of each line's string. Later on, when this content is passed to write, it is joined with , which will add newlines
Configuration menu - View commit details
-
Copy full SHA for b4e7106 - Browse repository at this point
Copy the full SHA b4e7106View commit details -
Change file system adapters to only write Strings
This separates the concerns, so the adapters only write **String**s, they don't do any joining or coercion.
Configuration menu - View commit details
-
Copy full SHA for 182c874 - Browse repository at this point
Copy the full SHA 182c874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a5f92d - Browse repository at this point
Copy the full SHA 6a5f92dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1f4389 - Browse repository at this point
Copy the full SHA f1f4389View commit details -
Configuration menu - View commit details
-
Copy full SHA for d456998 - Browse repository at this point
Copy the full SHA d456998View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d4dbc3 - Browse repository at this point
Copy the full SHA 8d4dbc3View commit details
Commits on Jun 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bcbac68 - Browse repository at this point
Copy the full SHA bcbac68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c5053c - Browse repository at this point
Copy the full SHA 1c5053cView commit details
Commits on Oct 11, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c8fa3d9 - Browse repository at this point
Copy the full SHA c8fa3d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4d36fc - Browse repository at this point
Copy the full SHA d4d36fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d873b27 - Browse repository at this point
Copy the full SHA d873b27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.