Remove content-length header from 101 Switching Protocols response #2164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 9110-8.6 (and RFC 7230 before it) states:
The websocket connect response is 101 (Switching Protocols) and should not contain
Content-Length
as specified above. Drogon's response incorrectly included theContent-Length
header.This causes an issue with the .NET websockets client implementation as described in this Stack Overflow question.
Using
setPassthrough
on Switching Protocols response suppresses theContent-Length
header as well asContent-Type
,Date
, andServer
. I added explicit code to add back theServer
header. I'm not sure how desirable that actually is.And there is a test added that fails without the code changes.