Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write_text to include newline variable #362

Merged
merged 5 commits into from
Sep 14, 2023

Conversation

pricemg
Copy link
Contributor

@pricemg pricemg commented Aug 31, 2023

As of python3.10 write_text in the pathlib module also has the optional argument newline (code).

Adding in the functionality to the open call.

cloudpathlib/cloudpath.py Outdated Show resolved Hide resolved
cloudpathlib/cloudpath.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #362 (e2d8f46) into master (d2079cc) will decrease coverage by 0.4%.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #362     +/-   ##
========================================
- Coverage    93.9%   93.5%   -0.4%     
========================================
  Files          22      22             
  Lines        1512    1512             
========================================
- Hits         1420    1414      -6     
- Misses         92      98      +6     
Files Changed Coverage Δ
cloudpathlib/cloudpath.py 91.9% <100.0%> (-0.4%) ⬇️

... and 2 files with indirect coverage changes

@pjbull
Copy link
Member

pjbull commented Sep 13, 2023

Looks good to me, thanks @pricemg! Could you also add a note to HISTORY.md? After that, I'll merge to a local branch to run the live tests and then into the main branch.

@pricemg
Copy link
Contributor Author

pricemg commented Sep 14, 2023

Thanks @pjbull done that now, thought i had more things to look into for those failing CICD checks so happy to hand it over :D

@pjbull pjbull changed the base branch from master to 362-live-tests September 14, 2023 16:29
@pjbull
Copy link
Member

pjbull commented Sep 14, 2023

Merging for live test run

@pjbull pjbull merged commit 7c4066b into drivendataorg:362-live-tests Sep 14, 2023
20 of 24 checks passed
pjbull added a commit that referenced this pull request Sep 14, 2023
* Update write_text to include newline variable

* Remove old docstring link

* Update cloudpathlib/cloudpath.py with black correction

* Remove use of io module

* update HISTORY.md

Co-authored-by: Matthew Price <[email protected]>
@pjbull
Copy link
Member

pjbull commented Oct 10, 2023

Thanks @pricemg, this has now shipped in version 0.16.0

msmitherdc added a commit to CRREL/cloudpathlib that referenced this pull request Nov 1, 2023
* Add "CloudPath" to possible cloud_path types (drivendataorg#342) (drivendataorg#343)

* Add "CloudPath" to possible cloud_path types (drivendataorg#342)

* Add to changelog

---------

Co-authored-by: Karol Zlot <[email protected]>

* Added with_stem support (drivendataorg#290) (drivendataorg#354)

* Added with_stem support

* Update readme (+small fix to make_support_table)

* Added test

* Update history.md

* Fallback to trivial CPython implementation if `with_stem` is not available

* Add a clarification comment

Co-authored-by: Daniel Oriyan <[email protected]>

* Fix flake8 errors (drivendataorg#359)

* Fix flake8 errors

* Fix wrong comparison

* Bump codecov action version; add codecov token

---------

Co-authored-by: Jay Qi <[email protected]>

* Update write_text to include newline variable (drivendataorg#362) (drivendataorg#363)

* Update write_text to include newline variable

* Remove old docstring link

* Update cloudpathlib/cloudpath.py with black correction

* Remove use of io module

* update HISTORY.md

Co-authored-by: Matthew Price <[email protected]>

* Add support for Python 3.12 (drivendataorg#364)

* passing tests

* remove print

* make method signatures match

* Remove unused import

* ignore type errors

* ignore more type errors

* make linting and tests work on multiple py versions

* add 3.12 to CI and pyproject

* use pytest-cases fork

* More performant walk implementation

* format

* update methods

* Test walk method

* Version agnostic tests

* update tests

* Add tests

* Order agnostic walk test

* Changes

* Update changelog

* sleep for flaky test

* Sleep flaky tests

* sleepier

* implement env var for local cache dir (drivendataorg#361)

* Add contributing guidelines (drivendataorg#367)

* contributing guidelines

* Apply suggestions from code review

Co-authored-by: Katie Wetstone <[email protected]>

* WIP

* Contrib tweaks and PR template

* clarification

* update history typo

---------

Co-authored-by: Katie Wetstone <[email protected]>

* Version bump

* format with black

* ignore type checking here

* update client reference

* update

* no need to change

---------

Co-authored-by: Peter Bull <[email protected]>
Co-authored-by: Karol Zlot <[email protected]>
Co-authored-by: Daniel Oriyan <[email protected]>
Co-authored-by: Jay Qi <[email protected]>
Co-authored-by: Jay Qi <[email protected]>
Co-authored-by: Matthew Price <[email protected]>
Co-authored-by: Peter Bull <[email protected]>
Co-authored-by: Katie Wetstone <[email protected]>
Co-authored-by: Michael D. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants