Workflows / CI: fixed & refactored #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexander-Senko
force-pushed
the
fix/ci
branch
7 times, most recently
from
551d317
to
4cefa6b
Compare
Alexander-Senko
commented
Sep 25, 2024
Alexander-Senko
force-pushed
the
fix/ci
branch
4 times, most recently
from
fa74c55
to
ce66d70
Compare
Alexander-Senko
commented
Sep 25, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
64
to
66
| - name: >- | ||
| Test outcome: ${{ steps.test.outcome }} | ||
| run: echo NOOP # every step must define a `uses` or `run` key |
There was a problem hiding this comment.
To see the actual result of tests without looking through logs.
Alexander-Senko
force-pushed
the
fix/ci
branch
from
ce66d70
to
f32a493
Compare
1 task
Alexander-Senko
commented
Sep 25, 2024
Comment on lines
+12
to
+16
| name: >- | ||
| rspec (${{ matrix.ruby }}) |
There was a problem hiding this comment.
I don't like the name, but we need it to match with the required workflows.
Does anyone have an access to change them? Otherwise, we have to support outdated ones for ages 😕
Alexander-Senko
force-pushed
the
fix/ci
branch
2 times, most recently
from
433eb1c
to
175640c
Compare
y-yagi
previously approved these changes
Sep 27, 2024
Alexander-Senko
force-pushed
the
fix/ci
branch
from
175640c
to
8074da7
Compare
I'm sorry, but another approval is needed due to suggested modifications made. |
## Fixed * Ruby 2.6 (see hotwired/turbo-rails/#681). ## Changed * Moved Rails versions to CI `matrix`. * Both edge and outdated Ruby / Rails versions may fail. * Use the latest RubyGems.
Alexander-Senko
force-pushed
the
fix/ci
branch
from
8074da7
to
9f858f1
Compare
y-yagi
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Changed
matrix.