support generating separate blob for prefetched files #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daiyongxuan
requested review from
jiangliu,
gaius-qi and
Desiki-high
and removed request for
a team
kevinXYin
reviewed
Oct 10, 2024
builder/src/chunkdict_generator.rs
Outdated
| let child = tree.get_node(&node.lock().unwrap().path()).unwrap(); | ||
| let mut child = child.node.lock().unwrap(); | ||
| child.layer_idx = prefetch_blob_index as u16; | ||
| for chunk in &mut child.chunks { |
There was a problem hiding this comment.
Hi , nice job!
how about just construct the new blob based on the compressed chunks from the original blob here, without needing to revert_files or modify the Blob::dump
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1629 +/- ##
==========================================
- Coverage 60.51% 60.04% -0.48%
==========================================
Files 146 147 +1
Lines 49178 49567 +389
Branches 46659 47048 +389
==========================================
+ Hits 29761 29762 +1
- Misses 17636 18023 +387
- Partials 1781 1782 +1
|
imeoer
changed the title
imeoer
reviewed
Oct 23, 2024
| blobs_dir_path.to_path_buf(), | ||
| prefetch_nodes, | ||
| ) | ||
| .unwrap(); |
There was a problem hiding this comment.
Error should be handled instead of calling unwrap.
Signed-off-by: daiyongxuan <[email protected]>
imeoer
reviewed
Oct 26, 2024
smoke/tests/native_layer_test.go
Outdated
| @@ -81,6 +81,7 @@ func (n *NativeLayerTestSuite) TestMakeLayers() test.Generator { | |||
| ctx.Runtime.RafsMode = scenario.GetString(paramRafsMode) | |||
| ctx.Runtime.EnablePrefetch = scenario.GetBool(paramEnablePrefetch) | |||
| ctx.Runtime.AmplifyIO = scenario.GetUInt64(paramAmplifyIO) | |||
| ctx.Runtime.ChunkDedupDb = scenario.GetString(paramChunkDedupDb) | |||
There was a problem hiding this comment.
This seems like an unnecessary merge commit.
imeoer
reviewed
Oct 26, 2024
| } | ||
| } | ||
|
|
||
| impl Read for BlobNodeReader { |
There was a problem hiding this comment.
It seems that File already implements Read, why do we still need to wrap it in a BlobNodeReader?
| let mut blob_ctx = BlobContext::from(ctx, &blob_info, ChunkSource::Build)?; | ||
| blob_ctx.chunk_count = 0; | ||
| blob_ctx.blob_meta_info_enabled = true; | ||
| let blob_writer = ArtifactWriter::new(crate::ArtifactStorage::SingleFile( |
There was a problem hiding this comment.
Should use ArtifactStorage::FileDir here.
builder/src/chunkdict_generator.rs
Outdated
| tree: &mut Tree, | ||
| ctx: &mut BuildContext, | ||
| bootstrap_mgr: &mut BootstrapManager, | ||
| blobtable: &mut RafsV6BlobTable, |
There was a problem hiding this comment.
blob_table, and need also to be compatible with RAFS v5.
Signed-off-by: daiyongxuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue #1589
The objective is to create an independent image layer to prioritize the fetching of necessary blobs during startup, enhancing performance.
Details
This introduces the "optimize" subcommand, which generates a new blob containing prefetch files and creates a new RAFS format bootstrap. This ensures compatibility with the nydus-image check and optimizes the startup process.