Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]nydus-image: modify compact subcommand #1489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

newthifans
Copy link
Contributor

Brief introduction
Modify command "nydus-image compact" to compress the small blob in the nydus image into a large blob

Basic Usage
nydus-image compact --bootstrap /path/to/nydus_bootstrap --compact-config /path/to/compact.json --backend-config /path/to/backend-config.json

@newthifans newthifans requested a review from a team as a code owner November 21, 2023 04:35
@newthifans newthifans requested review from jiangliu, changweige and hsiangkao and removed request for a team November 21, 2023 04:35
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #1489 (8d255a4) into master (767adcf) will increase coverage by 0.17%.
Report is 7 commits behind head on master.
The diff coverage is 21.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   62.51%   62.69%   +0.17%     
==========================================
  Files         123      123              
  Lines       43148    43268     +120     
  Branches    43148    43268     +120     
==========================================
+ Hits        26975    27125     +150     
+ Misses      14870    14831      -39     
- Partials     1303     1312       +9     
Files Coverage Δ
storage/src/meta/chunk_info_v1.rs 95.93% <100.00%> (+0.03%) ⬆️
src/bin/nydus-image/main.rs 0.77% <0.00%> (ø)
builder/src/compact.rs 79.40% <12.50%> (-1.16%) ⬇️

... and 6 files with indirect coverage changes

@adamqqqplay
Copy link
Member

@newthifans Thanks for your contribution! Can you add some unit tests to cover your changes?

…-config <config> --backend-config <backend-config> "

Signed-off-by: Zhao Yuan <[email protected]>
Signed-off-by: Zhao Yuan <[email protected]>
@newthifans newthifans changed the title nydus-image: modify compact subcommand [WIP]nydus-image: modify compact subcommand Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants