Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand Nydusify to support encrypted Nydus images #1386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taoohong
Copy link
Contributor

@taoohong taoohong commented Aug 1, 2023

  • convert: generate encrypted Ndyus images from OCI images.
  • check: check encrypted Nydus images.
  • mount: mount encrypted Nydus images.
  • build: build Nydus image with encrypted data blobs from a source directory.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Related Issue

@taoohong taoohong requested a review from a team as a code owner August 1, 2023 09:38
@taoohong taoohong requested review from liubin, luodw and adamqqqplay and removed request for a team August 1, 2023 09:38
@anolis-bot
Copy link
Collaborator

@taoohong , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88165

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@anolis-bot
Copy link
Collaborator

@taoohong , the title has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/88169

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1386 (dcfca7b) into master (f3cdd07) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
+ Coverage   46.38%   46.39%   +0.01%     
==========================================
  Files         123      123              
  Lines       38557    38557              
  Branches    38557    38557              
==========================================
+ Hits        17883    17889       +6     
+ Misses      19703    19697       -6     
  Partials      971      971              

see 2 files with indirect coverage changes

@taoohong taoohong marked this pull request as draft August 4, 2023 03:45
@taoohong taoohong marked this pull request as ready for review August 8, 2023 02:58
@anolis-bot
Copy link
Collaborator

@taoohong , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/89617

@anolis-bot
Copy link
Collaborator

@taoohong , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

* convert: generate encrypted Ndyus images from OCI images.
* check: check encrypted Nydus images.
* mount: mount encrypted Nydus images.
* build: build Nydus image with encrypted data blobs from a
source directory.

Signed-off-by: taohong <[email protected]>
@@ -425,6 +425,13 @@ func main() {
Usage: "File path to save the metrics collected during conversion in JSON format, for example: './output.json'",
EnvVars: []string{"OUTPUT_JSON"},
},
&cli.StringSliceFlag{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke test is required. Please also update doc

@@ -606,6 +614,12 @@ func main() {
Usage: "Path to the nydusd binary, default to search in PATH",
EnvVars: []string{"NYDUSD"},
},
&cli.StringSliceFlag{
Name: "decrypt-keys",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -765,6 +780,12 @@ func main() {
Usage: "The nydusd binary path, if unset, search in PATH environment",
EnvVars: []string{"NYDUSD"},
},
&cli.StringSliceFlag{
Name: "decrypt-keys",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -921,6 +943,14 @@ func main() {
Usage: "Path to the nydus-image binary, default to search in PATH",
EnvVars: []string{"NYDUS_IMAGE"},
},

&cli.StringSliceFlag{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants