chore: lock keys for optimistic transactions #3865
Open
+26
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Oct 4, 2024
| sd.local_mask |= OPTIMISTIC_EXECUTION; | ||
| shard->stats().tx_optimistic_total++; | ||
|
|
||
| RunCallback(shard); | ||
|
|
||
| // Check state again, it could've been updated if the callback returned AVOID_CONCLUDING flag. | ||
| // Only possible for single shard. | ||
| if (coordinator_state_ & COORD_CONCLUDING) | ||
| if (coordinator_state_ & COORD_CONCLUDING) { |
There was a problem hiding this comment.
@dranikpg At first I was confused by this because for execute_optimistic to be true we need coordinator_state_ & COORD_CONCLUDING. However, I found out by looking at the stream family, that there are transactions that start with this state and then they might AVOID_CONCLUDING depending on the callback result. I almost removed the if here 😄
kostasrim
commented
Oct 4, 2024
| @@ -1060,26 +1077,25 @@ bool Transaction::ScheduleInShard(EngineShard* shard, bool execute_optimistic) { | |||
| // Check if we can run immediately | |||
| if (shard_unlocked && execute_optimistic && | |||
| CheckLocks(GetDbSlice(shard->shard_id()), mode, lock_args)) { | |||
| // We need to acquire the fp locks because the executing callback | |||
| // within RunCallback might preempt. | |||
| acquire_fp_locks(shard_unlocked); | |||
There was a problem hiding this comment.
I also thought adding a check here and make acquire_fp_locks return a bool. But there is no really a need since CheckLocks gurantees that we hold none.
|
@dranikpg you are our transaction guy so plz let me know if I forgot anything -- highly likely 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not acquire any locks for transactions that are executing optimistically. However, this is problematic for callbacks that need to preempt (e.g. because a journal is active).
resolves #3841